Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Danger #132

Open
trinitytakei opened this issue Nov 26, 2024 · 1 comment
Open

Add Danger #132

trinitytakei opened this issue Nov 26, 2024 · 1 comment

Comments

@trinitytakei
Copy link
Member

trinitytakei commented Nov 26, 2024

Check for stuff like forgotten <% console %> or binding.irb as well as check out how others are using it

Make sure whatever can be done / makes sense to add to overcommit instead (to catch it sooner)

  • memoization
def foo
  @_foo = begin
     # setup foo
  end
end
def initialize(foo:)
  @foo = foo
end

def some_method_using_foo
  # ✅
  foo + 1 

  # ❌
  @foo + 1
end

private

attr_reader :foo
Copy link

linear bot commented Nov 26, 2024

RAI-45 Add Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant