Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed file provider workaround to fix security issue #659

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

M66B
Copy link
Contributor

@M66B M66B commented Jan 7, 2025

Refs #644

@vanniktech
Copy link
Contributor

Could you run ktlintFormat such that the build gets green?

@M66B
Copy link
Contributor Author

M66B commented Jan 7, 2025

I'll finish a fix for my own project, and update the pull request. An import will need to be removed to pass lint.

@M66B
Copy link
Contributor Author

M66B commented Jan 7, 2025

The pull request has been updated

@M66B
Copy link
Contributor Author

M66B commented Jan 7, 2025

Just for the record: the indentation was already 1 space. Anyway, this should be fixed too now.

@M66B
Copy link
Contributor Author

M66B commented Jan 7, 2025

Please try again. This was caused by my inexperience with Kotlin.

@vanniktech vanniktech merged commit fc3d4e7 into CanHub:main Jan 7, 2025
1 check passed
@vanniktech
Copy link
Contributor

No worries and thank you very much for fixing this issue!

@M66B
Copy link
Contributor Author

M66B commented Jan 7, 2025

You're very welcome.

Thank your for providing this useful library. I'm using it in FairEmail to let people edit images inserted into a message.

I think the related issue can be closed too now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants