Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the frontend components and layout of the application, as well as a minor update to the seed data. The main focus is on refactoring components to improve code readability and maintainability, and updating the layout and styles.
Refactoring and Component Updates:
DataTable Component:
className
prop and updated thediv
element to use thecn
utility for conditional class names. (app/frontend/components/data_table.tsx
, [1] [2]ExternalLink Component:
Link
toLinkIcon
and wrapped the anchor tag with theButton
component for consistent styling. (app/frontend/components/external_link.tsx
, [1] [2]Link Component:
Link
component that uses theButton
component andInertiaLink
from@inertiajs/react
. (app/frontend/components/link.tsx
, app/frontend/components/link.tsxR1-R15)UI Components:
Card
component with subcomponents forCardHeader
,CardTitle
,CardDescription
,CardContent
, andCardFooter
. (app/frontend/components/ui/card.tsx
, app/frontend/components/ui/card.tsxR1-R88)Button
,Input
,Separator
) to improve code formatting and consistency. (app/frontend/components/ui/button.tsx
, [1] [2];app/frontend/components/ui/input.tsx
, [3] [4];app/frontend/components/ui/separator.tsx
, [5] [6]Layout and Page Updates:
Application Layout:
Layout
component with aFooter
subcomponent for consistent page structure and styling. (app/frontend/layouts/application.tsx
, [1];app/frontend/layouts/application/footer.tsx
, [2]Page Updates:
companies/index
anderrors/not_found
pages to use the newLink
andCard
components for a more consistent UI. (app/frontend/pages/companies/index.tsx
, [1] [2];app/frontend/pages/errors/not_found.tsx
, [3]Seed Data Update:
website
andcareers_page
URLs in the seed data to use a more realistic URL. (db/seeds.rb
, db/seeds.rbL93-R94)