Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] layout improvements #53

Merged
merged 8 commits into from
Sep 22, 2024
Merged

[V2] layout improvements #53

merged 8 commits into from
Sep 22, 2024

Conversation

CalvinWalzel
Copy link
Owner

This pull request includes several changes to the frontend components and layout of the application, as well as a minor update to the seed data. The main focus is on refactoring components to improve code readability and maintainability, and updating the layout and styles.

Refactoring and Component Updates:

  • DataTable Component:

    • Added className prop and updated the div element to use the cn utility for conditional class names. (app/frontend/components/data_table.tsx, [1] [2]
  • ExternalLink Component:

    • Renamed Link to LinkIcon and wrapped the anchor tag with the Button component for consistent styling. (app/frontend/components/external_link.tsx, [1] [2]
  • Link Component:

  • UI Components:

    • Added a new Card component with subcomponents for CardHeader, CardTitle, CardDescription, CardContent, and CardFooter. (app/frontend/components/ui/card.tsx, app/frontend/components/ui/card.tsxR1-R88)
    • Updated existing UI components (Button, Input, Separator) to improve code formatting and consistency. (app/frontend/components/ui/button.tsx, [1] [2]; app/frontend/components/ui/input.tsx, [3] [4]; app/frontend/components/ui/separator.tsx, [5] [6]

Layout and Page Updates:

  • Application Layout:

    • Added a new Layout component with a Footer subcomponent for consistent page structure and styling. (app/frontend/layouts/application.tsx, [1]; app/frontend/layouts/application/footer.tsx, [2]
  • Page Updates:

    • Updated the companies/index and errors/not_found pages to use the new Link and Card components for a more consistent UI. (app/frontend/pages/companies/index.tsx, [1] [2]; app/frontend/pages/errors/not_found.tsx, [3]

Seed Data Update:

  • Seed Companies:
    • Updated the website and careers_page URLs in the seed data to use a more realistic URL. (db/seeds.rb, db/seeds.rbL93-R94)

@CalvinWalzel CalvinWalzel self-assigned this Sep 17, 2024
@CalvinWalzel CalvinWalzel force-pushed the v2/layout-improvements branch 3 times, most recently from 742a6ec to 96c95fe Compare September 18, 2024 07:41
Copy link
Collaborator

@GittavanderPol GittavanderPol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 and looks good!

@CalvinWalzel CalvinWalzel merged commit 1a9d3ec into version-2 Sep 22, 2024
4 checks passed
@CalvinWalzel CalvinWalzel deleted the v2/layout-improvements branch September 22, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants