[V2] Technology #49
Merged
[V2] Technology #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GittavanderPol
force-pushed
the
v2/technology
branch
from
adcca7a to
0cd8de6
Compare
CalvinWalzel
requested changes
Aug 25, 2024
app/models/company_technology.rb
Outdated
| belongs_to :technology | ||
|
|
||
| validates :company_id, uniqueness: { scope: :technology_id } | ||
| validates :technology_id, uniqueness: { scope: :company_id } |
There was a problem hiding this comment.
These two are redundant. Removing one of them should achieve the same result.
app/models/technology.rb
Outdated
|
|
||
| validates :name, presence: true, uniqueness: true | ||
| validates :background_color, | ||
| format: { with: /\A#(?:[0-9a-fA-F]{3}){1,2}\z/, message: "must be a valid hex color code" }, |
There was a problem hiding this comment.
Can we extract the regex into a constant?
class Technology < ApplicationRecord
HEX_COLOR_REGEX = /\A#(?:[0-9a-fA-F]{3}){1,2}\z/.freeze
# ...
validates :background_color,
format: { with: HEX_COLOR_REGEX, ... }We can move it to a custom validator once/if we need it in another model.
db/schema.rb
Outdated
| @@ -19,8 +19,28 @@ | |||
| t.string "website" | |||
| t.datetime "created_at", null: false | |||
| t.datetime "updated_at", null: false | |||
| t.text "introduction" | |||
There was a problem hiding this comment.
Can this be removed? I think it's a leftover from your local development database. Removing it manually from db/schema.rb is fine.
GittavanderPol
force-pushed
the
v2/technology
branch
from
08ef0e0 to
42e185d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to associate companies with technologies, allowing users to view technologies associated with each company. The most important changes include updates to the models, serializers, and frontend components to support this new feature.