Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open second view is broken after visyn script merge #424

Open
thinkh opened this issue Aug 23, 2022 · 1 comment
Open

Open second view is broken after visyn script merge #424

thinkh opened this issue Aug 23, 2022 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@thinkh
Copy link
Member

thinkh commented Aug 23, 2022

Environment

  • Release number or git hash: ec9c918
  • Browser: Chrome 104
  • Deployed / Local: both

Steps to reproduce the bug

  1. https://ordino-daily.caleydoapp.org/app/?
  2. Open a list of genes
  3. Select genes
  4. Open any second view

Observed Behavior

The second view does not open. The dev console shows the following error.

ViewWrapper.ts:343 Uncaught (in promise) TypeError: $app.scrollTo is not a function
    at ViewWrapper.scrollIntoView (ViewWrapper.ts:343:17)
    at ViewWrapper.modeChanged (ViewWrapper.ts:324:12)
    at set mode [as mode] (ViewWrapper.ts:422:10)
    at OrdinoApp.tsx:494:7
    at Array.forEach (<anonymous>)
    at OrdinoApp.focusImpl (OrdinoApp.tsx:484:22)
    at OrdinoApp.tsx:411:53
    at async ActionNode.createViewImpl [as f] (cmds.ts:67:22)

Expected Behavior

Switching to the second view should be possible again without an error.

Thanks for taking the time to fill out this bug report 🤗
Make sure there aren't any open/closed issues for this topic 😃

@thinkh thinkh added the type: bug Something isn't working label Aug 23, 2022
@thinkh thinkh self-assigned this Aug 23, 2022
@thinkh
Copy link
Member Author

thinkh commented Aug 23, 2022

With the visyn script merge (#421) the resolution of node modules has changed. That is probably the reason why jQuery plugins like scrollTo are not correctly loaded or registered to the "correct" jQuery instance. That's why the scrollTo function / plugin cannot be found and results in the error above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant