Added overall accuracy cell #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NMO13 Any idea why the x-axis in the detail plot is so cluttered? In malevo-daily it is correct...
|
thinkh
requested changes
Jul 3, 2018
src/ConfusionMatrix.ts
Outdated
| @@ -489,6 +497,19 @@ export class ConfusionMatrix implements IAppView { | |||
| }); | |||
| } | |||
|
|
|||
| renderOverallAccuracyCell(data: number[][], renderer: IMatrixRendererChain, labels: string[], singleEpochIndex: number[], colors: string[]) { | |||
| const maxVal = Math.max(...data.map((x: number[]) => Math.max(...x))); | |||
There was a problem hiding this comment.
Alternative to flatten the array first and use only one Math.max:
const maxVal = Math.max(...[].concat(...data));
src/ConfusionMatrix.ts
Outdated
| renderOverallAccuracyCell(data: number[][], renderer: IMatrixRendererChain, labels: string[], singleEpochIndex: number[], colors: string[]) { | ||
| const maxVal = Math.max(...data.map((x: number[]) => Math.max(...x))); | ||
|
|
||
| const res = { |
src/ConfusionMeasures.ts
Outdated
| return arr; | ||
| } | ||
|
|
||
| for(const m of matrices) { |
There was a problem hiding this comment.
Why don't you use map?
return matrices.map((m) => calcSummedPercent1(m));
Because its epoch granularity dependent.... I fix that. |
thinkh
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added overall accuracy cell to confusion matrix: