Add ascii-to-emoji replacer #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nnsense91
commented
Jan 14, 2025
•
nnsense91
commented
- Add replacer function
- Add unit-tests flow
- Add ci-tests stage
- Add to storybook
- Bump CI node version to 20
added 2 commits
January 14, 2025 16:52
nnsense91
commented
Jan 15, 2025
| * @returns {string} text with replacements | ||
| */ | ||
| export const asciiToEmoji = (inputString, options = {}) => { | ||
| if (typeof inputString !== "string") throw Error("inputString must be a string!") |
There was a problem hiding this comment.
Тут можно было бы возвращать неизмененный текст, но мне показалось это логичнее обрабатывать в каком-нибудь try/catch на месте.
elenik72
reviewed
Jan 15, 2025
elenik72
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.