Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert error types #1

Closed
Innectic opened this issue Jan 6, 2019 · 2 comments
Closed

Convert error types #1

Innectic opened this issue Jan 6, 2019 · 2 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@Innectic
Copy link
Member

Innectic commented Jan 6, 2019

Currently we just use Strings for all our Result errors. This should be changed into some kind of an enum so we actually know what the crap is happening.

@Innectic Innectic added this to the 0.1.0 milestone Jan 6, 2019
@Innectic Innectic self-assigned this Jan 6, 2019
@Innectic Innectic added the good first issue Good for newcomers label Jan 6, 2019
@Innectic
Copy link
Member Author

Innectic commented Jan 6, 2019

This should probably be done now, instead of after Constellation support is finished. Then, constellation support will just be done with the correct type of result error types.

@Innectic
Copy link
Member Author

Innectic commented Jan 6, 2019

I'm also thinking we should convert HandlerResult (renamed in the constellation branch) to a more generic system - maybe remove the Nothing variant, and use Option<HandlerResult>, and just have the variants of Error and Message. Maybe we could completely replace that with a result, but that might end up making it more complicated, instead of simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant