feature: Migrate all Syslog Images to Fontawesome Glyphs

Cacti · Oct 2, 2020 · f0287ab · f0287ab
1 parent 850e962
commit f0287ab
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,8 @@
 
 * issue#133: Saving Settings on the Syslog Tab are not retained in latest Cacti
 
+* feature: Migrate all Syslog Images to Fontawesome Glyphs
+
 --- 2.9 ---
 
 * issue#120: SQL syntax error for syslog when click browser back button

diff --git a/functions.php b/functions.php
@@ -566,7 +566,7 @@ function syslog_row_color($priority, $message) {
 		break;
 	}
 
-	print "<tr title='" . html_escape($message) . "' class='selectable $class syslogRow'>\n";
+	print "<tr title='" . html_escape($message) . "' class='tableRow selectable $class syslogRow'>";
 }
 
 function sql_hosts_where($tab) {

diff --git a/setup.php b/setup.php
@@ -1177,7 +1177,7 @@ function syslog_graph_buttons($graph_elements = array()) {
 					$host_id = syslog_db_fetch_cell('SELECT host_id FROM syslog_hosts ' . $sql_where);
 
 					if ($host_id) {
-						print "<a class='iconLink' href='" . htmlspecialchars($config['url_path'] . 'plugins/syslog/syslog.php?tab=syslog&reset=1&host=' . $host_id . '&date1=' . $date1 . '&date2=' . $date2) . "'><img src='" . $config['url_path'] . "plugins/syslog/images/view_syslog.png' alt='' title='" . __('Display Syslog in Range', 'syslog') . "'></a><br>";
+						print "<a class='iconLink' href='" . htmlspecialchars($config['url_path'] . 'plugins/syslog/syslog.php?tab=syslog&reset=1&host=' . $host_id . '&date1=' . $date1 . '&date2=' . $date2) . "' title='" . __('Display Syslog in Range', 'syslog') . "'><i class='deviceRecovering fas fa-exclamation-triangle'></i></a><br>";
 					}
 				}
 			}

diff --git a/syslog.php b/syslog.php
@@ -1499,7 +1499,7 @@ function syslog_syslog_legend() {
 	global $disabled_color, $notmon_color, $database_default;
 
 	html_start_box('', '100%', '', '3', 'center', '');
-	print '<tr>';
+	print '<tr class="">';
 	print "<td width='10%' class='logEmergency'>" . __('Emergency', 'syslog') . '</td>';
 	print "<td width='10%' class='logCritical'>"  . __('Critical', 'syslog')  . '</td>';
 	print "<td width='10%' class='logAlert'>"     . __('Alert', 'syslog')     . '</td>';
@@ -1519,7 +1519,7 @@ function syslog_log_legend() {
 	global $disabled_color, $notmon_color, $database_default;
 
 	html_start_box('', '100%', '', '3', 'center', '');
-	print '<tr>';
+	print '<tr class="">';
 	print "<td width='10%' class='logCritical'>" . __('Critical', 'syslog')      . '</td>';
 	print "<td width='10%' class='logWarning'>"  . __('Warning', 'syslog')       . '</td>';
 	print "<td width='10%' class='logNotice'>"   . __('Notice', 'syslog')        . '</td>';
@@ -1651,8 +1651,8 @@ function syslog_messages($tab = 'syslog') {
 				if (api_plugin_user_realm_auth('syslog_alerts.php')) {
 					$url = '';
 					if ($sm['mtype'] == 'main') {
-						$url .= "<a style='padding:1px' href='" . html_escape('syslog_alerts.php?id=' . $sm[$syslog_incoming_config['id']] . '&action=newedit&type=0') . "'><img src='" . $config['url_path'] . "plugins/syslog/images/add.png'></a>";
-						$url .= "<a style='padding:1px' href='" . html_escape('syslog_removal.php?id=' . $sm[$syslog_incoming_config['id']] . '&action=newedit&type=new&type=0') . "'><img src='" . $config['url_path'] . "plugins/syslog/images/delete.png'></a>";
+						$url .= "<a style='padding:1px' href='" . html_escape('syslog_alerts.php?id=' . $sm[$syslog_incoming_config['id']] . '&action=newedit&type=0') . "'><i class='deviceUp fas fa-plus-circle'></i>";
+						$url .= "<a style='padding:1px' href='" . html_escape('syslog_removal.php?id=' . $sm[$syslog_incoming_config['id']] . '&action=newedit&type=new&type=0') . "'><i class='deviceDown fas fa-minus-circle'></i>";
 					}
 
 					form_selectable_cell($url, $sm['seq'], '', 'left');
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,8 @@ @@
     * issue#133: Saving Settings on the Syslog Tab are not retained in latest Cacti
+    * feature: Migrate all Syslog Images to Fontawesome Glyphs
     --- 2.9 ---
     * issue#120: SQL syntax error for syslog when click browser back button
@@ Expand Down @@