Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

chore: change targetsdk and compilesdk to 29 #86

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

BumbleFlash
Copy link

This PR is to change the API level to 29.

"closes #77"

@BumbleFlash BumbleFlash requested a review from barbeau October 20, 2020 17:32
@BumbleFlash
Copy link
Author

@barbeau I read through the checklist and I think MUSER doesn't have anything in the codebase that could be potentially be affected. I also did a Ctrl + Shift + F on the Studio and I think it looks good to me. Also, I tested it out on my Pixel 3a (Android 11) and I didn't notice any crashes. IIRC, AVD manager currently doesn't have an Android 11 but I think you can also test it out on Android 10 with AP1 29? Lastly, changing the API level doesn't change the notification bar behaviour on my phone (#85)

@barbeau
Copy link
Member

barbeau commented Oct 20, 2020

@BumbleFlash Thanks! There should be an Android 11 emulator now if you update to the latest stable tools, I have one set up on my machine. Did you test to see if Firebase and Google Sheets logging works as expected on the Pixel 3a?

@BumbleFlash BumbleFlash changed the title chore: changed targetsdk and compilesdk to 29 chore: change targetsdk and compilesdk to 29 Oct 20, 2020
@BumbleFlash
Copy link
Author

@barbeau I double-checked Firebase logging an email mapping and it seems to work fine on my Pixel 3a.

Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@barbeau barbeau merged commit 37fd873 into usf Oct 20, 2020
@barbeau barbeau deleted the change-API-level branch October 20, 2020 20:49
@barbeau
Copy link
Member

barbeau commented Oct 20, 2020

@BumbleFlash Could you go ahead and do another PR to bump versionCode and versionName, and we'll get another release out with this included so more users can test?

@barbeau
Copy link
Member

barbeau commented Oct 20, 2020

You can just do a patch version - v1.1.2

@BumbleFlash
Copy link
Author

@barbeau Sounds good. Will surely do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change App target API to 29
2 participants