-
Notifications
You must be signed in to change notification settings - Fork 297
hhc nutritio-refactor ( fix error and add doc for the code) #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hhcgoodluck
wants to merge
190
commits into
CSC207-2024F-UofT:main
Choose a base branch
from
Cindyzzz616:hhc-nutrition-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
hhc nutritio-refactor ( fix error and add doc for the code) #354
hhcgoodluck
wants to merge
190
commits into
CSC207-2024F-UofT:main
from
Cindyzzz616:hhc-nutrition-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created a basic recipe, ingredient, and nutrition class to build upon
team member information
Refactoring Search Recipe Use Case to Follow Clean Architecture
additional parameters to recipeview constructor and fixed checkstyle errors
added handleSearch and cleaned up event listeners according to william's branch
…I key to use the AppConstants class instead
…arch test for now
created mock DAO and test for filter recipes use case; only filter search test for now
…View, added some of the methods needed for FolderView
completed test with coverage and overloading constructor in interactor
…its children classes
added section headers and some brief notes under each; also links to headers
Implemented folders feature, began refactoring to adhere to CA
# Conflicts: # src/main/java/data_access/RecipeIdDAO.java # src/main/java/data_access/ViewNutritionDataAccessImpl.java # src/main/java/view/IndividualRecipeView.java # src/main/java/view/NutritionView.java # src/test/java/use_case/nutrition/NutritionViewTest.java # src/test/java/use_case/nutrition/ViewNutritionDataAccessTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix error and add doc for the code