add azure option in result recording #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cqc-melf
force-pushed
the
melf/fix-resultrecording-in-base-profile
branch
from
72981a4 to
faf7c9e
Compare
cqc-melf
force-pushed
the
melf/fix-resultrecording-in-base-profile
branch
from
faf7c9e to
ad9cf66
Compare
cqc-melf
commented
Dec 12, 2024
| if qir_generator.has_wasm: | ||
| if profile == QIRProfile.AZUREADAPTIVE: | ||
|
|
||
| assert not qir_generator.has_wasm |
There was a problem hiding this comment.
My understanding is that we don't want to do wasm for azure.
There was a problem hiding this comment.
I think that's a fair assumption for now at least.
cqc-alec
reviewed
Dec 12, 2024
| if qir_generator.has_wasm: | ||
| if profile == QIRProfile.AZUREADAPTIVE: | ||
|
|
||
| assert not qir_generator.has_wasm |
There was a problem hiding this comment.
I think that's a fair assumption for now at least.
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
This reverts commit 6d0b9ce.
cqc-alec
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please summarise the changes.
Related issues
Please mention any github issues addressed by this PR.
Checklist