Skip to content

feat: Add ExtensionOp helpers #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

feat: Add ExtensionOp helpers #2072

merged 2 commits into from
Apr 15, 2025

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Apr 9, 2025

  • We had OpType::cast but were missing it in ExtensionOp itself.
  • Adds a ExtensionOp::extension_id call

@aborgna-q aborgna-q requested a review from a team as a code owner April 9, 2025 12:30
@aborgna-q aborgna-q requested a review from doug-q April 9, 2025 12:30
@aborgna-q aborgna-q changed the title feat: Add ExtensionOp::cast helper feat: Add ExtensionOp helper Apr 9, 2025
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (7626797) to head (d4cbe79).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-core/src/ops/custom.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2072      +/-   ##
==========================================
- Coverage   82.91%   82.90%   -0.01%     
==========================================
  Files         217      217              
  Lines       41529    41534       +5     
  Branches    37707    37712       +5     
==========================================
+ Hits        34433    34435       +2     
- Misses       5292     5295       +3     
  Partials     1804     1804              
Flag Coverage Δ
python 85.40% <ø> (ø)
rust 82.65% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aborgna-q aborgna-q changed the title feat: Add ExtensionOp helper feat: Add ExtensionOp helpers Apr 9, 2025
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@aborgna-q aborgna-q added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit fb5a561 Apr 15, 2025
26 of 27 checks passed
@aborgna-q aborgna-q deleted the ab/cast-extension-op branch April 15, 2025 09:42
This was referenced Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants