Multi-threaded type inference #41
Draft
Annotations
1 error and 11 warnings
|
Run HLint
HLint failed with status: 1. Warning (4), Suggestion (13)
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Run HLint:
brat/Brat/Eval.hs#L194
Warning in kindOf in module Brat.Eval: Redundant <&> ▫︎ Found: "(req (TypeOf e) <&> fst)\n >>=\n \\case\n EndType Braty (Left k) -> pure k\n EndType my ty\n -> typeErr\n $ \"End \"\n ++\n show e\n ++\n \" isn't a kind, it's type is \"\n ++\n case my of\n Braty -> show ty\n Kerny -> show ty" ▫︎ Perhaps: "req (TypeOf e)\n >>=\n (\\case\n EndType Braty (Left k) -> pure k\n EndType my ty\n -> typeErr\n $ \"End \"\n ++\n show e\n ++\n \" isn't a kind, it's type is \"\n ++\n case my of\n Braty -> show ty\n Kerny -> show ty)\n . fst"
|
|
Run HLint:
brat/Brat/Load.hs#L159
Suggestion in loadStmtsWithEnv in module Brat.Load: Use null ▫︎ Found: "length holes == 0" ▫︎ Perhaps: "null holes" ▫︎ Note: increases laziness
|
|
Run HLint:
brat/Brat/Checker/Helpers.hs#L142
Suggestion in pullPorts in module Brat.Checker.Helpers: Use uncurry ▫︎ Found: "\\ (pulled, rest) -> pulled ++ rest" ▫︎ Perhaps: "uncurry (++)" ▫︎ Note: increases laziness
|
|
Run HLint:
brat/Brat/Checker/Helpers.hs#L306
Suggestion in vecLayers in module Brat.Checker.Helpers: Redundant bracket ▫︎ Found: "(_, (VApp (VPar e) _))" ▫︎ Perhaps: "(_, VApp (VPar e) _)"
|
|
Run HLint:
brat/Brat/Checker/Helpers.hs#L308
Suggestion in vecLayers in module Brat.Checker.Helpers: Redundant bracket ▫︎ Found: "(my, (TVec ty (VNum n)))" ▫︎ Perhaps: "(my, TVec ty (VNum n))"
|
|
Run HLint:
brat/Brat/Checker/Helpers.hs#L311
Suggestion in vecLayers in module Brat.Checker.Helpers: Redundant bracket ▫︎ Found: "(Braty, (VFun Braty cty))" ▫︎ Perhaps: "(Braty, VFun Braty cty)"
|
|
Run HLint:
brat/Brat/Checker/Helpers.hs#L312
Suggestion in vecLayers in module Brat.Checker.Helpers: Redundant bracket ▫︎ Found: "(Kerny, (VFun Kerny cty))" ▫︎ Perhaps: "(Kerny, VFun Kerny cty)"
|
|
Run HLint:
brat/Brat/Checker/Monad.hs#L124
Suggestion in wrapper2 in module Brat.Checker.Monad: Avoid lambda ▫︎ Found: "\\ s -> pure (f s)" ▫︎ Perhaps: "pure . f"
|
|
Run HLint:
brat/Brat/Checker/Monad.hs#L135
Suggestion in localFC in module Brat.Checker.Monad: Redundant $ ▫︎ Found: "pure $ Nothing" ▫︎ Perhaps: "pure Nothing"
|
|
Run HLint:
brat/Brat/Checker/Monad.hs#L160
Suggestion in captureOuterLocals in module Brat.Checker.Monad: Move brackets to avoid $ ▫︎ Found: "(req $ AddCapture n (x, new)) >> (pure $ Just j)" ▫︎ Perhaps: "(req $ AddCapture n (x, new)) >> pure (Just j)"
|
Loading