Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-threaded type inference #41

Draft
wants to merge 86 commits into
base: holes
Choose a base branch
from
Draft

Multi-threaded type inference #41

wants to merge 86 commits into from

Conversation

acl-cqc
Copy link
Collaborator

@acl-cqc acl-cqc commented Oct 21, 2024

This now based off #59 which should come first, however, I'm not sure about all of the merge:

  • merge commit e6e37a9 has 22 failures, being the merge of previous 7c20289 (only 18 failures) with da57ef6 from feat: Allow writing holes which are solved by BRAT #59. I haven't identified what the 4 extra failures are but one of them is:
  • examples/infer.brat now fails with "Trying to remove Hope not in set: ". We probably need to think about RemoveHope, taken from feat: Allow writing holes which are solved by BRAT #59, this may not be correct with what we're doing here in this PR?
  • In Helpers.hs I put the getThunks check for hopes in vecLayers in order to share it between Braty and Kerny. This might be wrong given check' Hope raises an error for hopes in kernel code! So either (a) move the check for hopes back into getThunks or (b) allow hopes in kernels? In which case we probably want to hide that vecLayers (Helpers.hs lacks an export list)

@acl-cqc acl-cqc changed the base branch from main to holes December 9, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants