-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-threaded type inference #41
Draft
acl-cqc
wants to merge
86
commits into
holes
Choose a base branch
from
inference-wip/fork
base: holes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…val' into inference-wip/fork
This reverts commit 251455b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now based off #59 which should come first, however, I'm not sure about all of the merge:
examples/infer.brat
now fails with "Trying to remove Hope not in set: ". We probably need to think aboutRemoveHope
, taken from feat: Allow writing holes which are solved by BRAT #59, this may not be correct with what we're doing here in this PR?Helpers.hs
I put thegetThunks
check for hopes invecLayers
in order to share it between Braty and Kerny. This might be wrong givencheck' Hope
raises an error for hopes in kernel code! So either (a) move the check for hopes back intogetThunks
or (b) allow hopes in kernels? In which case we probably want to hide thatvecLayers
(Helpers.hs
lacks an export list)