Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace np.NAN with np.nan everywhere #22

Closed
wants to merge 1 commit into from
Closed

Replace np.NAN with np.nan everywhere #22

wants to merge 1 commit into from

Conversation

aekiss
Copy link

@aekiss aekiss commented Jan 15, 2025

fixes #21

@aekiss aekiss requested a review from anton-seaice January 15, 2025 05:36
@anton-seaice
Copy link
Contributor

Thanks @aekiss - it looks like the test dependencies also expect some numpy 1 features.

See

https://github.com/COSIMA/esmgrids/actions/runs/12782220423/job/35631353902?pr=22#step:5:97

We won't need the cice_from_mom step after the next ACCESS-OM3 release, so i suggest we just revert to numpy 1. We may not need this package going forward, otherwise well need to update the ocean_model_grid_generator to use numpy 2 before we use this.

Reverting to numpy 1 means the tests pass: #23

@aekiss
Copy link
Author

aekiss commented Jan 16, 2025

hm, ok but np.NAN appears in many places in the code, so I expect there will be things other than cice_from_mom that break under numpy 2 - are we happy to stay on numpy 1 indefinitely?

@anton-seaice
Copy link
Contributor

anton-seaice commented Jan 16, 2025

I think we won't really need this package once we stop using the CICE grid file (e.g. from the next OM3 release - 0.4.0) and its safe to assume itll work for a couple of years still with numpy 1

@aekiss aekiss mentioned this pull request Jan 16, 2025
@anton-seaice
Copy link
Contributor

Superseded by #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'numpy' has no attribute 'NAN'. Did you mean: 'nan'?
2 participants