Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deseas issues at boundaries #40

Open
aekiss opened this issue Oct 23, 2024 · 0 comments
Open

deseas issues at boundaries #40

aekiss opened this issue Oct 23, 2024 · 0 comments

Comments

@aekiss
Copy link
Contributor

aekiss commented Oct 23, 2024

There are a couple of bugs in topography_number_seas. These aren't worth fixing as they don't seem to cause problems, but I'm noting them here for reference in case it's useful later. They could both be fixed by rewriting topography_number_seas to use an enlarged seas array with copies of cells from the other side of the left, right and top boundaries, like depth_halo in topography_nonadvective.

  1. C-grid connectivity rules are used at the left and right boundaries, e.g. here, even if --grid_type B is specified
  2. the top boundary is not joined up like a tripole seam - e.g. the little boxes at the top of test_topo.png are converted to land, even though they connect to the ocean via the tripole seam

test_topo.png (white=ocean):
image

test_topoC.nc from topogtools deseas --input test_topo.nc --output test_topoC.nc --grid_type C (red=ocean):
Screenshot 2024-10-24 at 10 49 48 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant