Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Sensitivity DataFrame #491

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

drewejohnson
Copy link
Collaborator

Re-applies changes from #483 by @GrimFe

Grimaldi Federico and others added 3 commits August 7, 2023 15:05
(cherry picked from commit 991820e)
(cherry picked from commit 3a50d14)
Update as a consequence of my first contribution

(cherry picked from commit 6df2b83)
@GrimFe
Copy link

GrimFe commented Aug 28, 2023

Hi @drewejohnson,

Following up on what you proposed in my previous PR, I am going to PR to your branch (drewejohnson:drewj/reapply-sens-dataframe) with some test changes to fix my poor test implementation, which resulted in several tests not passing. This should keep tour full control on everything, if you have other preferred methodologies, please let me know.

It should now be fine concerning the test_sensitivity.py file; yet there is a not passing test related to the images produced by the plot method,
I do not really see how my implementation would affect that, so it looks like I am missing something.

Do you have any idea how to fix this?

@GrimFe
Copy link

GrimFe commented Aug 28, 2023

Hi @drewejohnson,

Following up on what you proposed in my previous PR, I am going to PR to your branch (drewejohnson:drewj/reapply-sens-dataframe) with some test changes to fix my poor test implementation, which resulted in several tests not passing. This should keep tour full control on everything, if you have other preferred methodologies, please let me know.

It should now be fine concerning the test_sensitivity.py file; yet there is a not passing test related to the images produced by the plot method, I do not really see how my implementation would affect that, so it looks like I am missing something.

Do you have any idea how to fix this?

Actually, I may not have the rights for this approach to the test fixing. Do you know more about this or can you please suggest a different way to edit the files?

Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants