Skip to content

Commit

Permalink
add an explicit warning about what happens if people gapfill pseudore…
Browse files Browse the repository at this point in the history
…actions

Thanks to @oxinabox for highlighting the issue

Closes #78
  • Loading branch information
exaexa committed Nov 22, 2024
1 parent 9e4be24 commit a4dd3b3
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions docs/src/examples/05g-gapfilling.jl
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ x2 = gap_filling_analysis(

other_filled_reactions = [k for (k, v) in x2.fill_flags if v != 0]

#md # !!! warning "Why is the gapfilling algorithm adding seemingly unneeded reactions?"
#md # By default, COBREXA does not do any "cleaning" on the universal model; all reactions that are present in that model will be potentially utilized in the new model, and all of them will need to respect their original bounds in the universal model. That becomes an issue with **reactions that are bounded to non-zero flux** (such as the `ATPM` reaction in the E. coli "core" model) -- since their flux is marked as necessarily non-zero to make any model feasible; they will need to be in the fill set, because otherwise their flux would be equal zero.
#md #
#md # As the simplest solution, all realistic uses of gapfilling should carefully check the set of universal reactions, and ideally exclude all exchanges and pseudoreactions.

# ## Model debugging: which metabolite is missing?
#
# Gap-filling is great for detecting various broken links and imbalances in
Expand Down

0 comments on commit a4dd3b3

Please sign in to comment.