Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3913: Develop Base Container Definition #2572

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

malessi
Copy link
Contributor

@malessi malessi commented Mar 3, 2025

JIRA Ticket:
BFD-3919

What Does This PR Do?

This PR introduces a Containerfile (generic Dockerfile) to build two separate, but related, Images for our Java-based and Python-based workloads. These Images are based off of AL2023, and include only the necessary dependencies.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

  • Building both Images locally using podman and running each image with the entrypoint as /bin/sh, verifying that:
    • The Java image has the latest 21 corretto (using java --version)
    • The Python image has Python 3.13 (using python --version)

Copy link
Member

@mjburling mjburling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@malessi malessi enabled auto-merge (squash) March 3, 2025 22:51
# default. This flag will be removed when "--default" is supported as a release feature
RUN uv python install python3.13 --preview --default

FROM python AS java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the python stuff in the java image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants