Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented soft delete feature for users resource #188

Merged
merged 8 commits into from
Mar 13, 2025
Merged

implemented soft delete feature for users resource #188

merged 8 commits into from
Mar 13, 2025

Conversation

talentedmrjones
Copy link
Collaborator

Added

  • migration to add delete column to users table

Changed

  • model/users FindUsers() now returns only users where delete=false
  • auth now returns http 401 unauthorized when deleted user tries to log in

closes #184

@talentedmrjones talentedmrjones marked this pull request as ready for review March 12, 2025 19:19
eschwein-usds
eschwein-usds approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@eschwein-usds eschwein-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer my question in the comments of backend/cmd/api/internal/migrations/008_users_soft_delete.go and you are good to go.

@talentedmrjones talentedmrjones merged commit fc426b9 into main Mar 13, 2025
10 checks passed
@talentedmrjones talentedmrjones deleted the 184-delete-a-user branch March 13, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschwein-usds eschwein-usds eschwein-usds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete a User
2 participants
@talentedmrjones @eschwein-usds