-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing integration stuff #73
Conversation
@lewisjared I discovered that I missed a good bit in the integration which meant tests ran but didn't include ilamb things. Now I have some errors, but these last ones I don't understand. Do you have any idea of what I have missed? |
Yup it turns out the tests are sensitive to new metrics and sample data so need to be tweaked each time either changes. I've got a fix for this in a pr I'm about to merge so hopefully that will resolve this #68 |
The changes look good though so feel free to assign it to me so I can merge once I fix the flakey test |
@@ -71,8 +71,8 @@ class GlobalMeanTimeseries(Metric): | |||
Calculate the global mean timeseries for a dataset | |||
""" | |||
|
|||
name = "Global Mean Timeseries" | |||
slug = "global-mean-timeseries" | |||
name = "ILAMB Global Mean Timeseries" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that the slug had to be globally unique. The intention was that it is unique for a provider. The constraint is that the combination of the provider slug + the metric slug was unique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a bunch (~10) failed tests due to some errors which reported 'unique slug' problems that were fixed when I made the change. But I will check this again.
Testing this locally after merging main looks to work
|
cc02dae
to
2817d10
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Description
Realized that I had missed some things needed for full integration.
Checklist
Please confirm that this pull request has done the following:
changelog/