-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ilamb3 integration #66
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
packages/ref-metrics-ilamb3/src/cmip_ref_metrics_ilamb3/example.py
Outdated
Show resolved
Hide resolved
@lewisjared Closed #63 in favor of this ILAMB integration, ready for you to take a look. I am on to additional metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
I've assigned this to you. The typical flow that I use for merging is that the person who the PR is assigned to does the merging when ready. I find this workflow works well with a distributed team. Often I might assign a PR to the reviewer so that they can review (potentially fix) and merge if they are happy, hopefully skipping another day of back and forward if tiny fixes are needed.
Description
An alternative integration through ilamb3.
Checklist
Please confirm that this pull request has done the following:
changelog/