Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ilamb3 integration #66

Merged
merged 5 commits into from
Jan 22, 2025
Merged

ilamb3 integration #66

merged 5 commits into from
Jan 22, 2025

Conversation

nocollier
Copy link
Contributor

@nocollier nocollier commented Jan 17, 2025

Description

An alternative integration through ilamb3.

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@nocollier nocollier requested a review from lewisjared January 17, 2025 18:15
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...trics-ilamb/src/cmip_ref_metrics_ilamb/__init__.py 100.00% <100.00%> (ø)
...etrics-ilamb/src/cmip_ref_metrics_ilamb/example.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@nocollier
Copy link
Contributor Author

@lewisjared Closed #63 in favor of this ILAMB integration, ready for you to take a look. I am on to additional metrics.

Copy link
Contributor

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

I've assigned this to you. The typical flow that I use for merging is that the person who the PR is assigned to does the merging when ready. I find this workflow works well with a distributed team. Often I might assign a PR to the reviewer so that they can review (potentially fix) and merge if they are happy, hopefully skipping another day of back and forward if tiny fixes are needed.

@nocollier nocollier merged commit 37ad1bb into CMIP-REF:main Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants