-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy pre-commit hook #52
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Closes #50 |
Since mypy is now run using pre-commit, this job could be removed, right? cmip-ref/.github/workflows/ci.yaml Lines 10 to 18 in 8515dbf
Could we also run the pre-commit hooks on draft pull requests, so I have a bit more confidence that what I'm doing is up to standards even when it's not yet ready for review? I.e. take out this line? cmip-ref/.github/workflows/ci.yaml Line 21 in 8515dbf
Unrelated, but in the same file: since we have the readthedocs build enabled for pull requests, we don't need this action anymore either, do we? cmip-ref/.github/workflows/ci.yaml Lines 30 to 46 in 8515dbf
|
Description
Adds pre-commit hook for mypy
Checklist
Please confirm that this pull request has done the following:
changelog/