forked from rectorphp/rector-symfony
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathAuthorizationCheckerIsGrantedExtractorRector.php
154 lines (130 loc) · 4.2 KB
/
AuthorizationCheckerIsGrantedExtractorRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
<?php
declare(strict_types=1);
namespace Rector\Symfony\Symfony44\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\ArrayItem;
use PhpParser\Node\Expr\BinaryOp\BooleanOr;
use PhpParser\Node\Expr\MethodCall;
use PHPStan\Type\ObjectType;
use Rector\NodeAnalyzer\ArgsAnalyzer;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://github.com/symfony/symfony/blob/4.4/UPGRADE-4.4.md#security
*
* @see \Rector\Symfony\Tests\Symfony44\Rector\MethodCall\AuthorizationCheckerIsGrantedExtractorRector\AuthorizationCheckerIsGrantedExtractorRectorTest
*/
final class AuthorizationCheckerIsGrantedExtractorRector extends AbstractRector
{
public function __construct(
private readonly ArgsAnalyzer $argsAnalyzer
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Change `$this->authorizationChecker->isGranted([$a, $b])` to `$this->authorizationChecker->isGranted($a) || $this->authorizationChecker->isGranted($b)`',
[
new CodeSample(
<<<'CODE_SAMPLE'
if ($this->authorizationChecker->isGranted(['ROLE_USER', 'ROLE_ADMIN'])) {
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
if ($this->authorizationChecker->isGranted('ROLE_USER') || $this->authorizationChecker->isGranted('ROLE_ADMIN')) {
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class];
}
/**
* @param MethodCall $node
*/
public function refactor(Node $node): MethodCall|BooleanOr|null
{
$objectType = $this->nodeTypeResolver->getType($node->var);
if (! $objectType instanceof ObjectType) {
return null;
}
$authorizationChecker = new ObjectType(
'Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface'
);
if (! $authorizationChecker->isSuperTypeOf($objectType)->yes()) {
return null;
}
if (! $this->nodeNameResolver->isName($node->name, 'isGranted')) {
return null;
}
$args = $node->getArgs();
if ($this->argsAnalyzer->hasNamedArg($args)) {
return null;
}
if (! isset($args[0])) {
return null;
}
$value = $args[0]->value;
if (! $value instanceof Array_) {
return null;
}
return $this->processExtractIsGranted($node, $value, $args);
}
/**
* @param Arg[] $args
*/
private function processExtractIsGranted(
MethodCall $methodCall,
Array_ $array,
array $args
): MethodCall|BooleanOr|null {
$exprs = [];
foreach ($array->items as $item) {
if ($item instanceof ArrayItem) {
$exprs[] = $item->value;
}
}
if ($exprs === []) {
return null;
}
$args[0]->value = $exprs[0];
$methodCall->args = $args;
if (count($exprs) === 1) {
return $methodCall;
}
$rightMethodCall = clone $methodCall;
$rightMethodCall->args[0] = new Arg($exprs[1]);
$newMethodCallRight = new MethodCall(
$methodCall->var,
$methodCall->name,
$rightMethodCall->args,
$methodCall->getAttributes()
);
$booleanOr = new BooleanOr($methodCall, $newMethodCallRight);
foreach ($exprs as $key => $expr) {
if ($key <= 1) {
continue;
}
$rightMethodCall = clone $methodCall;
$rightMethodCall->args[0] = new Arg($expr);
$newMethodCallRight = new MethodCall(
$methodCall->var,
$methodCall->name,
$rightMethodCall->args,
$methodCall->getAttributes()
);
$booleanOr = new BooleanOr($booleanOr, $newMethodCallRight);
}
return $booleanOr;
}
}