forked from rectorphp/rector-symfony
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathGetRequestRector.php
253 lines (207 loc) · 6.92 KB
/
GetRequestRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
<?php
declare(strict_types=1);
namespace Rector\Symfony\Symfony30\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Param;
use PhpParser\Node\Scalar\String_;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\Exception\ShouldNotHappenException;
use Rector\PhpParser\Node\BetterNodeFinder;
use Rector\Rector\AbstractRector;
use Rector\Symfony\Bridge\NodeAnalyzer\ControllerMethodAnalyzer;
use Rector\Symfony\TypeAnalyzer\ControllerAnalyzer;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Symfony\Tests\Symfony30\Rector\ClassMethod\GetRequestRector\GetRequestRectorTest
*/
final class GetRequestRector extends AbstractRector
{
/**
* @var string
*/
private const REQUEST_CLASS = 'Symfony\Component\HttpFoundation\Request';
private ?string $requestVariableAndParamName = null;
public function __construct(
private readonly ControllerMethodAnalyzer $controllerMethodAnalyzer,
private readonly ControllerAnalyzer $controllerAnalyzer,
private readonly BetterNodeFinder $betterNodeFinder,
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Turns fetching of Request via `$this->getRequest()` to action injection',
[
new CodeSample(
<<<'CODE_SAMPLE'
class SomeController
{
public function someAction()
{
$this->getRequest()->...();
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
use Symfony\Component\HttpFoundation\Request;
class SomeController
{
public function someAction(Request $request)
{
$request->...();
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node): ?Node
{
if (! $this->controllerAnalyzer->isInsideController($node)) {
return null;
}
$hasChanged = false;
foreach ($node->getMethods() as $classMethod) {
$changedClassMethod = $this->refactorClassMethod($classMethod);
if ($changedClassMethod instanceof ClassMethod) {
$hasChanged = true;
}
}
if ($hasChanged) {
return $node;
}
return null;
}
private function resolveUniqueName(ClassMethod $classMethod, string $name): string
{
$candidateNames = [];
foreach ($classMethod->params as $param) {
$candidateNames[] = $this->getName($param);
}
$bareName = $name;
$prefixes = ['main', 'default'];
while (in_array($name, $candidateNames, true)) {
$name = array_shift($prefixes) . ucfirst($bareName);
}
return $name;
}
private function isActionWithGetRequestInBody(ClassMethod $classMethod): bool
{
if (! $this->controllerMethodAnalyzer->isAction($classMethod)) {
return false;
}
$containsGetRequestMethod = $this->containsGetRequestMethod($classMethod);
if ($containsGetRequestMethod) {
return true;
}
/** @var MethodCall[] $getMethodCalls */
$getMethodCalls = $this->betterNodeFinder->find($classMethod, function (Node $node): bool {
if (! $node instanceof MethodCall) {
return false;
}
if (! $node->var instanceof Variable) {
return false;
}
return $this->nodeNameResolver->isName($node->name, 'get');
});
foreach ($getMethodCalls as $getMethodCall) {
if ($this->isGetMethodCallWithRequestParameters($getMethodCall)) {
return true;
}
}
return false;
}
private function isGetRequestInAction(ClassMethod $classMethod, MethodCall $methodCall): bool
{
// must be $this->getRequest() in controller
if (! $methodCall->var instanceof Variable) {
return false;
}
if (! $this->nodeNameResolver->isName($methodCall->var, 'this')) {
return false;
}
if (! $this->isName($methodCall->name, 'getRequest') && ! $this->isGetMethodCallWithRequestParameters(
$methodCall
)) {
return false;
}
return $this->controllerMethodAnalyzer->isAction($classMethod);
}
private function containsGetRequestMethod(ClassMethod $classMethod): bool
{
return (bool) $this->betterNodeFinder->find((array) $classMethod->stmts, function (Node $node): bool {
if (! $node instanceof MethodCall) {
return false;
}
if (! $node->var instanceof Variable) {
return false;
}
if (! $this->isName($node->var, 'this')) {
return false;
}
return $this->nodeNameResolver->isName($node->name, 'getRequest');
});
}
private function isGetMethodCallWithRequestParameters(MethodCall $methodCall): bool
{
if (! $this->isName($methodCall->name, 'get')) {
return false;
}
if (count($methodCall->args) !== 1) {
return false;
}
$firstArg = $methodCall->getArgs()[0];
if (! $firstArg->value instanceof String_) {
return false;
}
$string = $firstArg->value;
return $string->value === 'request';
}
private function getRequestVariableAndParamName(): string
{
if ($this->requestVariableAndParamName === null) {
throw new ShouldNotHappenException();
}
return $this->requestVariableAndParamName;
}
private function refactorClassMethod(ClassMethod $classMethod): null|ClassMethod
{
$this->requestVariableAndParamName = $this->resolveUniqueName($classMethod, 'request');
if (! $this->isActionWithGetRequestInBody($classMethod)) {
return null;
}
$fullyQualified = new FullyQualified(self::REQUEST_CLASS);
$classMethod->params[] = new Param(new Variable(
$this->getRequestVariableAndParamName()
), null, $fullyQualified);
$this->traverseNodesWithCallable((array) $classMethod->stmts, function (Node $node) use (
$classMethod
): ?Variable {
if (! $node instanceof MethodCall) {
return null;
}
if ($this->isGetRequestInAction($classMethod, $node)) {
return new Variable($this->getRequestVariableAndParamName());
}
return null;
});
return $classMethod;
}
}