pio_errorhandling call was in the wrong location

[jedwards4b]

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

• Short (1 sentence) summary of your PR:
  Call to pio_seterrorhandling was in the wrong location as pio_read_darray was called with no check of return status.

• Developer(s):
  Jim Edwards

• Suggest PR reviewers from list in the column to the right.

• Please copy the PR test results link or provide a summary of testing completed below.
  Tested CESM F case hybrid restart from B case. Without this change the model hangs with no obvious error message, with this change the model aborts with appropriate error message.

• How much do the PR code changes differ from the unmodified code?

  • bit for bit
  • different at roundoff level
  • more substantial

• Does this PR create or have dependencies on Icepack or any other models?

  • Yes
  • No

• Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.

  • Yes
  • No

• Does this PR add any new test cases?

  • Yes
  • No

• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)

  • Yes
  • No, does the documentation need to be updated at a later time?
    • Yes
    • No

• Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

[anton-seaice]

Thanks Jim - I think this means we should remove these two lines:

CICE/cicecore/cicedyn/infrastructure/io/io_pio2/ice_restart.F90

Lines 770 to 771 in 1a89c78

	call ice_pio_check(status, &
	subname//" ERROR: reading var "//trim(vname),file=__FILE__,line=__LINE__)

as status would never be returned for a failure ?

[jedwards4b]

Yes, I think that you are correct.