Review after code scanning #3259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add of layerId in device twin * #2998 Quartz migration for SendPlanningCommand * #2856 Disable built-in device model deletion * #3238 Update view when a device is unchecked * 3239 Allow to delete a planning from client * 3239 Allow to delete a planning * 2998 Schedule commands * #3239 Change checkboxes for layers displayed * Merge from main * 2516 add supportLoRaFeatures tag in template file * #3250 Import device list using the template given * #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models * #3251 Import device - data overwritten * Unit tests * Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com> * #2958 Remove 'Connection State' and 'Last status update' columns * #3023 startupOrder not supported in Edge Device Model schema --------- Co-authored-by: E068097 <julie.ramos_ext@michelin.com> Co-authored-by: judramos <ramos.julie.63@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-vnext #3259 +/- ##
==============================================
+ Coverage 83.12% 84.69% +1.57%
==============================================
Files 327 328 +1
Lines 12428 12522 +94
Branches 980 990 +10
==============================================
+ Hits 10331 10606 +275
+ Misses 1807 1606 -201
- Partials 290 310 +20 ☔ View full report in Codecov by Sentry. |
kbeaugrand
force-pushed
the
main-vnext
branch
from
d6f81cc to
fee43dc
Compare
kbeaugrand
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?