Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_analysis_finished hook #990

Closed
1 of 4 tasks
yankovs opened this issue Oct 9, 2024 · 2 comments
Closed
1 of 4 tasks

on_analysis_finished hook #990

yankovs opened this issue Oct 9, 2024 · 2 comments

Comments

@yankovs
Copy link
Contributor

yankovs commented Oct 9, 2024

Feature Category

  • Correctness
  • User Interface / User Experience
  • Performance
  • Other (please explain)

Describe the problem

It would be useful to have an on_analysis_finished hook. It would be called when an active analysis finishes and should have a signature that includes the analysis object or at least ID and the hash of the sample

Also, there are other on_analysis_* of stuff like on_analysis_starts and so on that could be interesting

@yankovs
Copy link
Contributor Author

yankovs commented Oct 9, 2024

@yankovs
Copy link
Contributor Author

yankovs commented Oct 11, 2024

Closed as this seems to be more appropriate to be a feature of karton. I don't see how MWDB can know when an analysis is finished without polling for status all the time. It's ok for the web interface but not good otherwise.

Moved to: CERT-Polska/karton#260

@yankovs yankovs closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant