Skip to content

Commit

Permalink
Remove return type from get iam auth
Browse files Browse the repository at this point in the history
Since botocore doesn't have typings by default, this will not work unless we settle on something less specific than S3 client or add typing stubs to dependencies. In my opinion it is not worth it for this small method
  • Loading branch information
yankovs authored Jan 15, 2024
1 parent 5ab4a7f commit ea10a7f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions karton/core/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
InstanceMetadataFetcher,
InstanceMetadataProvider,
)
from botocore.client import S3
from botocore.session import get_session
from redis import AuthenticationError, StrictRedis
from redis.client import Pipeline
Expand Down Expand Up @@ -154,7 +153,7 @@ def __init__(
aws_secret_access_key=secret_key,
)

def iam_auth_s3(self, endpoint: str) -> Optional[S3]:
def iam_auth_s3(self, endpoint: str):
boto_session = get_session()
iam_providers = [
ContainerProvider(),
Expand Down

0 comments on commit ea10a7f

Please sign in to comment.