Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msgRepeatOptions value #60

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

mwodahl
Copy link

@mwodahl mwodahl commented Feb 15, 2024

Updates the RsuMsgRepeatOptions value used by SnmpNTCIP1218Protocol.java to use the correct value of 00 instead of the previous incorrect value of C0.

Additionally, updates SnmpSessionTest.java to reflect this change.

These updates have been deployed in dev and were verified to correctly deposit TIMs onto RSUs using NTCIP1218.

Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me & the unit tests are passing!

@dmccoystephenson dmccoystephenson marked this pull request as draft February 16, 2024 21:25
@dmccoystephenson
Copy link
Member

Marking this as a draft for now to prevent it from being merged until the changes in #61 have been pushed through to USDOT dev.

@dmccoystephenson
Copy link
Member

The changes in #61 have been merged into USDOT dev via usdot-jpo-ode#535, so we should be good to push changes to CDOT dev without it affecting the release. I am removing the 'draft' designation from this PR.

@dmccoystephenson dmccoystephenson marked this pull request as ready for review February 19, 2024 17:53
Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm! Compiles and unit tests pass

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for making this change

@payneBrandon payneBrandon merged commit 0e8e3f4 into dev Feb 20, 2024
2 of 4 checks passed
@payneBrandon payneBrandon deleted the Update/1218-msgRepeatOptions branch February 20, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants