-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors for manage users Okta pagination #8432
Conversation
Updating this with the GraphQL changes and instructions for testing the endpoint via Postman |
|
@@ -164,28 +164,29 @@ void getPagedUsersAndStatusInCurrentOrg_success() { | |||
|
|||
checkApiUserWithStatus(users.get(0), "admin@example.com", "Andrews", UserStatus.ACTIVE); | |||
checkApiUserWithStatus(users.get(1), "bobbity@example.com", "Bobberoo", UserStatus.ACTIVE); | |||
checkApiUserWithStatus( | |||
users.get(2), "allfacilities@example.com", "Williams", UserStatus.ACTIVE); | |||
checkApiUserWithStatus(users.get(2), "invalid@example.com", "Irwin", UserStatus.ACTIVE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the result of the test change because the user list is now returning in alphabetical order? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! It now relies on the same alphabetical ordering that the current non-paginated endpoint uses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one question about the tests! worked as expected on dev5! Nice fix, Mike!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EP working as expected for me -- great work on this Mike!
BACKEND PULL REQUEST
Related Issue
Changes Proposed
Testing
pageContent.content
is the list of search results itself.pageContent.totalElements
refers to the total number of search results for that specific query. If the search query is empty, this will be the same as thetotalUsersInOrg
totalUsersInOrg
is needed to distinguish between when we have zero search results for that particular query (totalElements = 0) and when the organization actually has no users configured (rarely seen by support admins but still need to handle that case)