-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
34 port notebooks under modeldocs to quarto #35
Conversation
This is ready for review, @dylanhmorris, @natemcintosh, @AFg6K7h4fhy2, or @SamuelBrand1 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments @gvegayoncdc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge when you're ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted one typo
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
* Porting to quarto and adding a makefile entry to render them * Now it should be easier to deal with pre-commit under docs (only skipping cache) * Forgot to remove the pyrenew_demo notebook * Update model/Makefile * Fixing typos * Removes progress bar - adds doc/ figures - sets jupyter as kernel * Update model/docs/getting-started.qmd Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> --------- Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
…39) * Copy doc from wastewater model on Hosp Admin to class * Rename metaclasses to metaclass (#36) * Create typos.yaml (#42) * Create typos.yaml * Does this make it run on the whole repo? * remove trailing whitespace * Delete .github/workflows/typos.yaml trying to use typos in pre-commit instead * Update .pre-commit-config.yaml add typos to pre-commit * fixed typos * 34 port notebooks under modeldocs to quarto (#35) * Porting to quarto and adding a makefile entry to render them * Now it should be easier to deal with pre-commit under docs (only skipping cache) * Forgot to remove the pyrenew_demo notebook * Update model/Makefile * Fixing typos * Removes progress bar - adds doc/ figures - sets jupyter as kernel * Update model/docs/getting-started.qmd Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> --------- Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> * Extra mathematical description of discrete delay distributions (#44) * Update description of discrete delay distributions * remove double desciption * minor eq fix * Update equations.md * update equations.md contents * Update equations.md * fix contents * Escaping tau * Adding deterministic obs and process to the equation * Cleaning the quarto documents and working on the getting started diagram * Flexible IHR (now RandomVariable) * Adding weekday and phosp effect to latent hosp * Adding back figures * Adding a test for deterministic/stochastic weekday effect * Typo Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> * Correcting tests (class name) and improving readme a bit * Adding deterministic module (midway, expected to fail) [skip ci] * Refactoring I0 and gen_int (expected to fail) [skip ci] * gen_int and I0 now are directly passed to the models * In latent hosp, change inf_hosp_int to inform_hosp (clearer name) * Adding missing figures (pyrenew demo was not compiling) * Renaming inform_hosp * Removing defaults for hosp rate * Changing language (initial infections) + adding section to getting-started * Update model/src/pyrenew/latent/hospitaladmissions.py Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> * Addressing comments on default priors and varnames * Rt is not default now for basic model * Commas and title * Update model/src/pyrenew/latent/hospitaladmissions.py Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> * Renaming hosp reporting variable in latent var * Renaming hosp report * Update model/src/pyrenew/latent/hospitaladmissions.py Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> * Final renaming of vars in tests * Different vector for hosp_report_prob_dist in tests --------- Co-authored-by: George G. Vega Yon <xrd4@cdc.gov> Co-authored-by: George G Vega Yon <156135298+gvegayoncdc@users.noreply.github.com> Co-authored-by: Nate McIntosh <NMcIntosh@cdc.gov> Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> Co-authored-by: Samuel Brand <48288458+SamuelBrand1@users.noreply.github.com> Co-authored-by: George G. Vega Yon <g.vegayon@gmail.com> Co-authored-by: Dylan H. Morris <dzl1@cdc.gov>
qmd
versions of the jupyter notebooks (and their md versions).*_cache
, if needed.