Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

34 port notebooks under modeldocs to quarto #35

Merged
8 commits merged into from
Mar 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2024

  • Added the qmd versions of the jupyter notebooks (and their md versions).
  • Added a couple of makefile entries to make building easier.
  • Under model/docs. pre-commit will only check *_cache, if needed.

@ghost ghost linked an issue Mar 21, 2024 that may be closed by this pull request
5 tasks
model/Makefile Outdated Show resolved Hide resolved
George G Vega Yon and others added 2 commits March 21, 2024 10:28
@ghost
Copy link
Author

ghost commented Mar 22, 2024

This is ready for review, @dylanhmorris, @natemcintosh, @AFg6K7h4fhy2, or @SamuelBrand1 :)

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments @gvegayoncdc

model/docs/getting-started.md Outdated Show resolved Hide resolved
model/docs/getting-started.md Outdated Show resolved Hide resolved
model/docs/getting-started.qmd Outdated Show resolved Hide resolved
@ghost ghost requested a review from dylanhmorris March 25, 2024 18:18
dylanhmorris
dylanhmorris previously approved these changes Mar 25, 2024
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when you're ready.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one typo

model/docs/getting-started.qmd Outdated Show resolved Hide resolved
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
@ghost ghost merged commit 55126ad into main Mar 25, 2024
3 checks passed
@ghost ghost deleted the 34-port-notebooks-under-modeldocs-to-quarto branch March 25, 2024 22:33
ghost pushed a commit that referenced this pull request Mar 27, 2024
* Porting to quarto and adding a makefile entry to render them

* Now it should be easier to deal with pre-commit under docs (only skipping cache)

* Forgot to remove the pyrenew_demo notebook

* Update model/Makefile

* Fixing typos

* Removes progress bar - adds doc/ figures - sets jupyter as kernel

* Update model/docs/getting-started.qmd

Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>

---------

Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
gvegayon added a commit that referenced this pull request Apr 3, 2024
…39)

* Copy doc from wastewater model on Hosp Admin to class

* Rename metaclasses to metaclass (#36)

* Create typos.yaml (#42)

* Create typos.yaml

* Does this make it run on the whole repo?

* remove trailing whitespace

* Delete .github/workflows/typos.yaml

trying to use typos in pre-commit instead

* Update .pre-commit-config.yaml

add typos to pre-commit

* fixed typos

* 34 port notebooks under modeldocs to quarto (#35)

* Porting to quarto and adding a makefile entry to render them

* Now it should be easier to deal with pre-commit under docs (only skipping cache)

* Forgot to remove the pyrenew_demo notebook

* Update model/Makefile

* Fixing typos

* Removes progress bar - adds doc/ figures - sets jupyter as kernel

* Update model/docs/getting-started.qmd

Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>

---------

Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>

* Extra mathematical description of discrete delay distributions (#44)

* Update description of discrete delay distributions

* remove double desciption

* minor eq fix

* Update equations.md

* update equations.md contents

* Update equations.md

* fix contents

* Escaping tau

* Adding deterministic obs and process to the equation

* Cleaning the quarto documents and working on the getting started diagram

* Flexible IHR (now RandomVariable)

* Adding weekday and phosp effect to latent hosp

* Adding back figures

* Adding a test for deterministic/stochastic weekday effect

* Typo

Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>

* Correcting tests (class name) and improving readme a bit

* Adding deterministic module (midway, expected to fail) [skip ci]

* Refactoring I0 and gen_int (expected to fail) [skip ci]

* gen_int and I0 now are directly passed to the models

* In latent hosp, change inf_hosp_int to inform_hosp (clearer name)

* Adding missing figures (pyrenew demo was not compiling)

* Renaming inform_hosp

* Removing defaults for hosp rate

* Changing language (initial infections) + adding section to getting-started

* Update model/src/pyrenew/latent/hospitaladmissions.py

Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>

* Addressing comments on default priors and varnames

* Rt is not default now for basic model

* Commas and title

* Update model/src/pyrenew/latent/hospitaladmissions.py

Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>

* Renaming hosp reporting variable in latent var

* Renaming hosp report

* Update model/src/pyrenew/latent/hospitaladmissions.py

Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>

* Final renaming of vars in tests

* Different vector for hosp_report_prob_dist in tests

---------

Co-authored-by: George G. Vega Yon <xrd4@cdc.gov>
Co-authored-by: George G Vega Yon <156135298+gvegayoncdc@users.noreply.github.com>
Co-authored-by: Nate McIntosh <NMcIntosh@cdc.gov>
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
Co-authored-by: Samuel Brand <48288458+SamuelBrand1@users.noreply.github.com>
Co-authored-by: George G. Vega Yon <g.vegayon@gmail.com>
Co-authored-by: Dylan H. Morris <dzl1@cdc.gov>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port notebooks under model/docs to quarto
2 participants