Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added log #62

Merged
merged 1 commit into from
Jan 23, 2025
Merged

added log #62

merged 1 commit into from
Jan 23, 2025

Conversation

ndduc01
Copy link
Collaborator

@ndduc01 ndduc01 commented Jan 23, 2025

Notes

Please include a summary of the change and which issue is fixed or which feature is added.

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

@ndduc01 ndduc01 merged commit 91cbb8d into main Jan 23, 2025
1 check passed
@@ -152,7 +155,7 @@
@RequestHeader(name = "endRow", defaultValue = "0", required = false) String endRow,
@RequestHeader(name = "initialLoad", defaultValue = "false", required = false) String initialLoadApplied,
@RequestHeader(name = "allowNull", defaultValue = "false", required = false) String allowNull) throws DataExchangeException {

logger.info("Fetching Data for Data Availability, Table {}", tableName);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
@@ -194,6 +197,7 @@
public ResponseEntity<Integer> dataSyncTotalRecords(@PathVariable String tableName,
@RequestParam String timestamp,
@RequestHeader(name = "initialLoad", defaultValue = "false", required = false) String initialLoadApplied) throws DataExchangeException {
logger.info("Fetching Data Count for Data Availability, Table {}", tableName);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants