Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AutoRod #5798

Open
wants to merge 33 commits into
base: nextgen
Choose a base branch
from
Open

Conversation

sqlerrorthing
Copy link
Contributor

@sqlerrorthing sqlerrorthing commented Mar 4, 2025

Auto use fishing rod to PVP.

The original code was taken from LiquidBounce Legacy.

Coded by @zyklone4096 (in #930)
Ported & recoded by @sqlerrorthing

closes #3693
closes #4397
closes #5526
closes #5114

@1zun4 1zun4 requested a review from superblaubeere27 March 4, 2025 17:50
@sqlerrorthing sqlerrorthing marked this pull request as ready for review March 5, 2025 01:49
@@ -0,0 +1,68 @@
@file:Suppress("MaxLineLength")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bc long link in kdoc.

* The original code was taken from [LiquidBounce Legacy](https://github.com/CCBlueX/LiquidBounce/blob/legacy/src/main/java/net/ccbluex/liquidbounce/features/module/modules/combat/AutoRod.kt).

@1zun4
Copy link
Member

1zun4 commented Mar 5, 2025

So, I have tried the Auto Rod on Gamster Classic - but it barely works, it pulls back before it reaches the target. It also does not switch back to the sword without the use of Auto Weapon. I don't know.

@superblaubeere27
Copy link
Contributor

There is another PR which implements this better. I am working on this other PR.

@sqlerrorthing
Copy link
Contributor Author

sqlerrorthing commented Mar 6, 2025

So, I have tried the Auto Rod on Gamster Classic - but it barely works, it pulls back before it reaches the target. It also does not switch back to the sword without the use of Auto Weapon. I don't know.

it pulls back before it reaches the target

added the setting OnTargetReach

It also does not switch back to the sword

maybe i fixed that in 97f8383 (no), in 3f7a0b4?

@sqlerrorthing
Copy link
Contributor Author

sqlerrorthing commented Mar 6, 2025

it's swapping slots back before release the rod, idk why

interaction.stopUsingItem(player)
resetSlot
?.takeIf { player.inventory.selectedSlot != it }
?.let {
player.inventory.selectedSlot = it
interaction.syncSelectedSlot()
}

@sqlerrorthing
Copy link
Contributor Author

There is another PR which implements this better. I am working on this other PR.

where?

# Conflicts:
#	src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/elytratarget/AutoFirework.kt
#	src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/misc/ModuleAutoPearl.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants