feat(HUD): Centered Crosshair #5652
Open
+131
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccetl
reviewed
Feb 17, 2025
There was a problem hiding this comment.
If the original source is under the MIT license, a copy right notice must be included. Please read the license of the project (https://github.com/JustAlittleWolf/centered-crosshair/blob/main/LICENSE).
Also, I think this should not be the default behavior of the client. Either it should be an option, or, the solution I would prefer, would be to have the crosshairs in a theme so that it can be fully customized, even with logic.
|
Customizable crosshairs would be awesome. For now I'll just add a setting to HUD though. |
1zun4
requested changes
Mar 1, 2025
| @@ -111,6 +115,28 @@ private void hookFreeCamRenderCrosshairInThirdPerson(DrawContext context, Render | |||
| } | |||
| } | |||
|
|
|||
| @Redirect(method = "renderCrosshair", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/DrawContext;drawGuiTexture(Ljava/util/function/Function;Lnet/minecraft/util/Identifier;IIII)V", ordinal = 0)) | |||
There was a problem hiding this comment.
Please do not use @Redirect. Instead use e.g. @WrapOperation, @ModifyExpressionValue ... etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crosshair is not actually centered in vanilla. This fixes it.
Credit: https://github.com/JustAlittleWolf/centered-crosshair/