Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-83 | 통합테스트 kt 전환 및 kotest 도입 #211

Merged
merged 11 commits into from
Sep 20, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-83

Description

dto에 대한 kt 전환 시 통합테스트가 깨지는 문제를 방지하기 위해 통합테스트에 대하여 리팩토링을 진행했습니다.

Core Code

etc

@lcomment lcomment added refactor 비즈니스 변경 없는 수정 test 테스트 작성 labels Sep 19, 2024
@lcomment lcomment requested a review from YongsHub September 19, 2024 14:08
@lcomment lcomment self-assigned this Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

Test Results

 40 files   40 suites   30s ⏱️
213 tests 213 ✅ 0 💤 0 ❌
214 runs  214 ✅ 0 💤 0 ❌

Results for commit e529a7c.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #211      +/-   ##
=============================================
+ Coverage      92.14%   92.93%   +0.78%     
- Complexity       329      338       +9     
=============================================
  Files            109      109              
  Lines            967      976       +9     
  Branches          34       36       +2     
=============================================
+ Hits             891      907      +16     
+ Misses            58       49       -9     
- Partials          18       20       +2     
Files with missing lines Coverage Δ Complexity Δ
...pi/dto/event/EmailWithVerificationCodeSendEvent.kt 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...ain/java/com/cakk/api/dto/event/ErrorAlertEvent.kt 100.00% <100.00%> (ø) 4.00 <4.00> (?)
...com/cakk/api/dto/event/IncreaseSearchCountEvent.kt 100.00% <100.00%> (ø) 2.00 <2.00> (?)
.../java/com/cakk/api/listener/SearchEventListener.kt 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...src/main/java/com/cakk/api/mapper/EventMapper.java 96.55% <100.00%> (ø) 6.00 <2.00> (ø)
...in/java/com/cakk/api/service/cake/CakeService.java 97.22% <100.00%> (+0.07%) 11.00 <0.00> (+1.00)
...in/java/com/cakk/api/service/shop/ShopService.java 98.63% <100.00%> (+0.01%) 21.00 <0.00> (+1.00)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e3e5e...e529a7c. Read the comment docs.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User id값 생성되지 않으면 단위 테스트 실패할 때가 종종 있습니다

.parameter(String::class.java)
.parameter(role.javaClass)
).sample()
.set("id", Arbitraries.longs().greaterOrEqual(10))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user 생성자 이렇게 생성하면 id 값 지정 안될텐데 되나요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

되다가 안되다가 하는데, 왜 그럴까요? 일단은 머지하고, 관련해서 해결해보죠. 각종 테스트에서 특정 부분에 계속 에러가 터지네요.. (전에 CakeShop 터지는거처럼요)

@lcomment lcomment merged commit b054e51 into develop Sep 20, 2024
3 checks passed
@lcomment lcomment deleted the refactor/CAKK-83 branch September 20, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정 test 테스트 작성
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants