-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor | CAKK-83 | 통합테스트 kt 전환 및 kotest 도입 #211
Conversation
Test Results 40 files 40 suites 30s ⏱️ Results for commit e529a7c. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #211 +/- ##
=============================================
+ Coverage 92.14% 92.93% +0.78%
- Complexity 329 338 +9
=============================================
Files 109 109
Lines 967 976 +9
Branches 34 36 +2
=============================================
+ Hits 891 907 +16
+ Misses 58 49 -9
- Partials 18 20 +2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User id값 생성되지 않으면 단위 테스트 실패할 때가 종종 있습니다
.parameter(String::class.java) | ||
.parameter(role.javaClass) | ||
).sample() | ||
.set("id", Arbitraries.longs().greaterOrEqual(10)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user 생성자 이렇게 생성하면 id 값 지정 안될텐데 되나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
되다가 안되다가 하는데, 왜 그럴까요? 일단은 머지하고, 관련해서 해결해보죠. 각종 테스트에서 특정 부분에 계속 에러가 터지네요.. (전에 CakeShop 터지는거처럼요)
CAKK-83
dto에 대한 kt 전환 시 통합테스트가 깨지는 문제를 방지하기 위해 통합테스트에 대하여 리팩토링을 진행했습니다.