Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

Add including files #15

Open
suicider opened this issue Mar 27, 2016 · 5 comments
Open

Add including files #15

suicider opened this issue Mar 27, 2016 · 5 comments

Comments

@suicider
Copy link
Member

The status_template file includes some style sheets like includes/amazium.css. We can fork the files if the license is suitable for us. And it is good to have a small comment in the README.

@Chaos99
Copy link
Contributor

Chaos99 commented Oct 30, 2016

proposed fix in #23

@Chaos99
Copy link
Contributor

Chaos99 commented Oct 30, 2016

still missing:
in status_template:

images/favicon.ico
images/apple-touch-icon.png
images/apple-touch-icon-72x72.png
images/apple-touch-icon-114x114.png

includes/smoothscroll.js

in base.css:
../img/ui.totop.png

all missing from current server and

in status_template:

http://jqueryjs.googlecode.com/files/jquery-1.3.js

not available on target server. Based on developers.google.com this should be replaced by https://ajax.googleapis.com/ajax/libs/jquery/3.1.0/jquery.min.js if actually needed. A local copy could be used too, if needed, but I won't create one without a further comment here.

@izzy
Copy link
Member

izzy commented Nov 8, 2016

We could probably just heavily simplify the page and remove the JS libs.

The favicon and Apple Touch Icons are optional but will be polled by the browser anyways. I'm not sure we ever had one, so if anyone feels like they're up to the challenge of graphic design for 16x16px graphic...

@izzy izzy added the bug label Nov 8, 2016
@Chaos99
Copy link
Contributor

Chaos99 commented Nov 8, 2016

I could probably do the favicon, but I would leave the JS-simplification to someone with more experience.
Will you create separate issues for this?

@izzy
Copy link
Member

izzy commented Nov 8, 2016

With simplification I meant: Throw that JS out. It's not necessary by any means, so everything that's JavaScript and below <!-- To Top scripts --> is just useless eyecandy that slows down page loading anyways.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants