Skip to content

EDU-638: Gen 2 React Nav links - Blueprints #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

uttej-vsk
Copy link
Contributor

@uttej-vsk uttej-vsk commented Apr 9, 2025

Description

This PR is part of the parent ticket: https://builder-io.atlassian.net/browse/EDU-121, but it focuses on the React code per this ticket EDU-638 Once approved, I will raise another PR for all the other frameworks.

Copy link

changeset-bot bot commented Apr 9, 2025

⚠️ No Changeset found

Latest commit: d77474f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@uttej-vsk uttej-vsk requested a review from sidmohanty11 April 9, 2025 18:56
Copy link

gitguardian bot commented Apr 9, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11707119 Triggered Generic High Entropy Secret 07830c5 packages/sdks/snippets/react/src/routes/blueprints/NavLinks.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented Apr 9, 2025

View your CI Pipeline Execution ↗ for commit d77474f.

Command Status Duration Result
nx test @e2e/nuxt ✅ Succeeded 7m 54s View ↗
nx test @e2e/qwik-city ✅ Succeeded 8m 4s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 7m 39s View ↗
nx test @e2e/react-sdk-next-14-app ✅ Succeeded 6m 53s View ↗
nx test @e2e/remix ✅ Succeeded 5m 1s View ↗
nx test @e2e/angular-16-ssr ✅ Succeeded 6m 29s View ↗
nx test @e2e/angular-16 ✅ Succeeded 6m 26s View ↗
nx test @e2e/react-sdk-next-15-app ✅ Succeeded 6m 6s View ↗
Additional runs (36) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-04-09 21:15:56 UTC

@uttej-vsk uttej-vsk changed the title Blueprints: Nav links - React Gen 2 EDU-638 - Blueprints: Nav links - React Gen 2 Apr 9, 2025
@uttej-vsk uttej-vsk changed the title EDU-638 - Blueprints: Nav links - React Gen 2 EDU-638: Blueprints Nav links - React Gen 2 Apr 9, 2025
@uttej-vsk uttej-vsk changed the title EDU-638: Blueprints Nav links - React Gen 2 EDU-638: React Gen 2 Nav links - Blueprints Apr 9, 2025
@uttej-vsk uttej-vsk changed the title EDU-638: React Gen 2 Nav links - Blueprints EDU-638: Gen 2 React Nav links - Blueprints Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant