Skip to content

Commit

Permalink
Revert "Feat/register component devtools" (#3620)
Browse files Browse the repository at this point in the history
Reverts #3619


I'm not sure anymore that this is actually needed
  • Loading branch information
samijaber authored Oct 8, 2024
1 parent a15696e commit cbece4a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 33 deletions.
12 changes: 0 additions & 12 deletions .changeset/few-ties-move.md

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { fetch } from '../../../functions/get-fetch.js';
import { isBrowser } from '../../../functions/is-browser.js';
import { isEditing } from '../../../functions/is-editing.js';
import { isPreviewing } from '../../../functions/is-previewing.js';
import { sendRegisterComponentMessage } from '../../../functions/register-component.js';
import { createRegisterComponentMessage } from '../../../functions/register-component.js';
import { _track } from '../../../functions/track/index.js';
import { getInteractionPropertiesForEvent } from '../../../functions/track/interaction.js';
import { getDefaultCanTrack } from '../../../helpers/canTrack.js';
Expand Down Expand Up @@ -291,7 +291,8 @@ export default function EnableEditor(props: BuilderEditorProps) {
Object.values<ComponentInfo>(
props.builderContextSignal.value.componentInfos
).forEach((registeredComponent) => {
sendRegisterComponentMessage(registeredComponent);
const message = createRegisterComponentMessage(registeredComponent);
window.parent?.postMessage(message, '*');
});
window.addEventListener(
'builder:component:stateChangeListenerActivated',
Expand Down
15 changes: 0 additions & 15 deletions packages/sdks/src/functions/register-component.ts
Original file line number Diff line number Diff line change
@@ -1,25 +1,10 @@
import type { RegisteredComponent } from '../context/types.js';
import type { ComponentInfo } from '../types/components.js';

export const createRegisterComponentMessage = (info: ComponentInfo) => ({
type: 'builder.registerComponent',
data: serializeIncludingFunctions(info),
});

export const sendRegisterComponentMessage = (info: ComponentInfo) => {
window.parent?.postMessage(createRegisterComponentMessage(info), '*');
};

/**
* @private
* @description This is a private internal function that is used to register a component from the Builder DevTools.
* Do not use this function directly.
*/
export const registerComponentFromDevTools = (info: RegisteredComponent) => {
const { component: _, ...rest } = info;
sendRegisterComponentMessage(rest);
};

// eslint-disable-next-line @typescript-eslint/ban-types
const serializeFn = (fnValue: Function) => {
const fnStr = fnValue.toString().trim();
Expand Down
5 changes: 1 addition & 4 deletions packages/sdks/src/server-index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ export type { ComponentInfo } from './types/components.js';
*/
export { isEditing } from './functions/is-editing.js';
export { isPreviewing } from './functions/is-previewing.js';
export {
createRegisterComponentMessage,
registerComponentFromDevTools,
} from './functions/register-component.js';
export { createRegisterComponentMessage } from './functions/register-component.js';

export { register } from './functions/register.js';
export type { InsertMenuConfig, InsertMenuItem } from './functions/register.js';
Expand Down

0 comments on commit cbece4a

Please sign in to comment.