fix: workspace applet wayland support #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EbonJaeger
force-pushed
the
fix/workspace-applet-wayland-support
branch
from
e0a304e to
d1bf679
Compare
EbonJaeger
force-pushed
the
fix/workspace-applet-wayland-support
branch
from
d1bf679 to
6f9c937
Compare
The big thing is that the applet no longer crashes when a new window is opened. When a window is opened, it may not yet have an application assigned to it. When that happens, set the item's icon to a generic one, and wait for it to update naturally. In practice, I have yet to see the generic icon; it's always been updated by the time I can see it.
Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
EbonJaeger
force-pushed
the
fix/workspace-applet-wayland-support
branch
from
6f9c937 to
4c32aa2
Compare
JoshStrobl
changed the title
fossfreedom
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a few things for the workspace applet:
The only other outstanding issue that I know of so far is that hovering the mouse over the add workspace button when it's set to only show on hover causes the revealer to keep opening and closing in rapid succession for as long as the mouse is there.
This should fix #470. If any further refinements are needed, they can be done later in separate PRs.
Submitter Checklist
git rebase -i(if needed)