Skip to content

Commit

Permalink
Fix talon PIDF scaling.
Browse files Browse the repository at this point in the history
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
  • Loading branch information
thenetworkgrinch committed Jan 18, 2024
1 parent 4e97eb5 commit 5e47110
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/main/deploy/swerve/falcon/modules/pidfproperties.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"iz": 0
},
"angle": {
"p": 0.138888888888,
"p": 100,
"i": 0,
"d": 0,
"f": 0,
"iz": 0.00083333333
"iz": 0.32
}
}
6 changes: 0 additions & 6 deletions src/main/java/swervelib/motors/TalonFXSwerve.java
Original file line number Diff line number Diff line change
Expand Up @@ -240,12 +240,6 @@ public void configureCANStatusFrames(
@Override
public void configurePIDF(PIDFConfig config)
{
if(!isDriveMotor)
{
config.p *= 360;
config.i *= 360;
config.d *= 360;
}

TalonFXConfigurator cfg = motor.getConfigurator();
cfg.refresh(configuration.Slot0);
Expand Down

0 comments on commit 5e47110

Please sign in to comment.