Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging AS with NTP #191

Open
kreczko opened this issue Mar 9, 2016 · 2 comments
Open

Merging AS with NTP #191

kreczko opened this issue Mar 9, 2016 · 2 comments
Labels
discussion
Milestone
13 TeV proper

Comments

@kreczko
Copy link
Member

kreczko commented Mar 9, 2016

As part of the slides I am going to show you today I would like to start the discussion about merging the two projects.
Currently NTP does

  • add content to the event
  • writes the TTree
  • creates the BLT
  • selects events
  • writes histograms (selection flow)
  • applies scale factors

AS does similar things:

  • writes a TTree
  • writes histograms
  • applies scale factors
  • selects events

I probably missed a few things here and there, please do let me know and I will add them here.

The goal is to come up with a list of tasks that needs to be done so we can take AS out of the loop.
@kreczko kreczko added this to the 13 TeV proper milestone Mar 9, 2016
This was referenced Mar 17, 2016
Open
Open
@kreczko
Copy link
Member Author

kreczko commented Mar 17, 2016

As I started writing new code I realised we should use a namespace.
And since I am bad with names, I picked ntp. Other suggestions are welcome.

@kreczko
Copy link
Member Author

kreczko commented Oct 11, 2016 •
edited
Loading

AS merged with NTP in #248, now we have to cut AS use down.

@kreczko kreczko closed this as completed Oct 11, 2016
@kreczko kreczko reopened this Oct 11, 2016
kreczko added a commit to kreczko/NTupleProduction that referenced this issue Feb 1, 2017
@kreczko
added EventUserData as part of BristolTopGroup#191
8d90974
kreczko added a commit to kreczko/NTupleProduction that referenced this issue Feb 1, 2017
@kreczko
added EventUserData as part of BristolTopGroup#191
d66f802
kreczko added a commit to kreczko/NTupleProduction that referenced this issue Feb 1, 2017
@kreczko
added EventUserData as part of BristolTopGroup#191
bd9d86a
EmyrClement pushed a commit that referenced this issue Feb 3, 2017
@kreczko @EmyrClement
Global variables for each selection (#285)
60342f4 
* marked a few producers & analysers as deprecated

* added global variables to PATUtilities

* added main NTP library as dependency of NTP plugins

* added EventUserData as part of #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
13 TeV proper
Development

No branches or pull requests
1 participant
@kreczko