Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate docker compose file in staging and production for backup #850

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

AthulyaMS
Copy link
Collaborator

@AthulyaMS AthulyaMS requested a review from shimilgithub July 18, 2024 04:26
@AthulyaMS AthulyaMS self-assigned this Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this file is empty?

Copy link
Collaborator Author

@AthulyaMS AthulyaMS Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know how that file become empty .I updated it again

@@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v2
- name: Start dependancies
working-directory: ./docker
run: docker compose up -d
run: docker compose -f docker-compose-staging.yml up -d

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this needs to happen only for staging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimilgithub Actually do we need this built-n-test in staging and production ?
Since we have both compose file now ,inorder to run the built-n-test ,we need to specify one thats why I added staging here .I think this file is using at the stage of local to github .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per this , during release also staging docker compose will run

run: docker compose -f docker-compose-staging.yml run vachan-api-test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here also

@shimilgithub shimilgithub merged commit 69815b7 into Bridgeconn:version-2 Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants