Misc Bug Fixes : SDK-2530, SDK-2532 #1465
Open
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes : - Fixed isLinkingRelatedRequest function to allow opens if tracking is disabled and spotlight identifier is present. - Fixed race condition for push notification on cold launch.
gdeluna-branch
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2530 -- Fix Init Race for Push notifications
https://branch.atlassian.net/browse/SDK-2530
SDK-2532 -- If tracking is disabled and app is launched via spotlight results, linking request is not sent.
https://branch.atlassian.net/browse/SDK-2532
Summary
Fixes :
handlePushNotificationAPI which is called inside didReceiveRemoteNotification. SoinitSessionWithLaunchOptionsis updated to not to send and extra open and call callback if app is launched via push notification.Type Of Change
Testing Instructions
cc @BranchMetrics/saas-sdk-devs for visibility.