Skip to content

Commit

Permalink
chore: make workflow run on pull request (fixes #651)
Browse files Browse the repository at this point in the history
  • Loading branch information
bjornstar authored and Borewit committed Jun 28, 2024
1 parent 4a00de1 commit ce2646d
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions .github/workflows/nodejs-ci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
name: Node.js CI
on: push
on:
pull_request:
branches: [ "master" ]

jobs:

Expand All @@ -9,9 +11,9 @@ jobs:

steps:

- uses: actions/checkout@v2
- uses: actions/checkout@v4

- uses: actions/setup-node@v1
- uses: actions/setup-node@v4
with:
node-version: 16.x

Expand All @@ -28,7 +30,7 @@ jobs:
run: yarn run build

- name: Upload build
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: build
path: |
Expand All @@ -46,23 +48,23 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [14.x, 16.x, 18.x, 20.x]

steps:

- name: 'Checkout the repository'
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Test with Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Install dependencies
run: yarn install --ignore-engines

- name: Download build
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: build

Expand Down

0 comments on commit ce2646d

Please sign in to comment.