Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade ethereumjs-tx from 1.3.7 to 2.1.2 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Boomtokn
Copy link

snyk-top-banner

Snyk has created this PR to upgrade ethereumjs-tx from 1.3.7 to 2.1.2.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


⚠️ Warning: This PR contains major version upgrade(s), and may be a breaking change.

  • The recommended version is 4 versions ahead of your current version.

  • The recommended version was released 5 years ago.

Release notes
Package name: ethereumjs-tx
  • 2.1.2 - 2019-12-19
    • Added support for the MuirGlacier HF by updating the ethereumjs-common dependency to v1.5.0
  • 2.1.1 - 2019-08-30
    • Added support for Istanbul reduced non-zero call data gas prices (EIP-2028), PR #171
  • 2.1.0 - 2019-07-06

    Using testnets and custom/private networks is now easier

    This release is focused on making this library easier to use in chains other than mainnet.

    Using standard testnets can be as easy as passing their names to the Transaction constructor. For example, new Transaction(rawTx, {chain: 'ropsten', hardfork: 'byzantium'}) is enough to use this library with Ropsten on Byzantium.

    If you are using a custom network, you can take advantage of ethereumjs-common, which contains all the network parameters. In this version of ethereumjs-tx you can use its new Common.forCustomNetwork to create a Common instance based on a standard network with some parameters changed. You can see an example of how to do this [here (https://redirect.github.com/ethereumjs/ethereumjs-common/blob/9e624f86107cea904d8171524130d92c99bf9302/src/index.ts).

    List of changes:

    • Upgraded ethereumjs-common to ^1.3.0
    • Added more documentation and examples on how to create transactions for public testnets and custom networks.
  • 2.0.0 - 2019-06-07

    TypeScript / Module Import / Node Support

    First TypeScript based release of the library, see PR #145 for details.

    This comes along with some changes on the API, Node import of the exposed classes now goes like this:

    const EthereumTx = require('ethereumjs-transaction').Transaction
    const FakeEthereumTx = require('ethereumjs-transaction').FakeTransaction

    The library now also comes with a type declaration file distributed along with the package published.

    Along with this release we drop official support for Node versions 4,5 and 6. Officially tested versions are now Node 8, 10 and 11 (see PRs #138 and #146).

    Hardfork Support / Official Test Updates

    Along with a long overdue update of the official Ethereum Transaction tests (see PRs #131 and #138 for FakeTransaction) and an introduction of setting chain and hardfork by using our shared ethereumjs-common class (see PR #131) the transaction library now supports all HFs up to the Petersburg hardfork, see [constructor option docs (https://redirect.github.com/ethereumjs/ethereumjs-tx/blob/master/docs/interfaces/transactionoptions.md) for information on instantiation and default values (current hardfork default: petersburg).

    API Changes:

    • Removal of the data.chainId parameter, use the opts.chain parameter or a custom Common instance

    Default EIP-155 Support

    Along with defaulting to a post-Spurious Dragon HF replay protection from EIP-155 is now activated by default. Transactions are subsequently also by default signed with EIP-155 replay protection, see PRs #153, #147 and #143.

    This comes with some changes in how different v values passed on instantiation or changed on runtime are handled:

    • The constructor throws if the v value is present, indicates that EIP-155 was enabled, and the chain id it indicates doesn't match the one of the internal common object
    • No default v is set. If a transaction isn't signed, it would be an empty buffer
    • If v is changed after construction its value is validated in its setter

    For activating non-EIP-155 behavior instantiate the transaction with a pre-Spurious Dragon hardfork option.

  • 1.3.7 - 2018-07-25
    • Fix bug causing FakeTransaction.from to not retrieve sender address from tx signature, see PR #118
from ethereumjs-tx GitHub release notes

Important

  • Warning: This PR contains a major version upgrade, and may be a breaking change.
  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade ethereumjs-tx from 1.3.7 to 2.1.2.

See this package in npm:
ethereumjs-tx

See this project in Snyk:
https://app.snyk.io/org/boomtokn/project/801774dc-2ee3-4933-b791-827a2684e154?utm_source=github&utm_medium=referral&page=upgrade-pr
@Boomtokn
Copy link
Author

Boomtokn commented Feb 25, 2025

Snyk checks have failed. 5 issues have been found so far.

Icon Severity Issues
Critical 2
High 3
Medium 0
Low 0

security/snyk check is complete. 5 issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/mocha@5.2.0 environment, filesystem Transitive: shell +9 1.79 MB boneskull
npm/truffle@4.1.17 None 0 37 MB cruzmolina
npm/web3-provider-engine@14.2.1 Transitive: environment +1 2.13 MB kumavis
npm/web3@0.20.7 None 0 7.93 MB frozeman

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/underscore@1.9.1 ⚠︎
Git dependency npm/web3@0.20.7 ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What are git dependencies?

Contains a dependency which resolves to a remote git URL. Dependencies fetched from git URLs are not immutable and can be used to inject untrusted code or reduce the likelihood of a reproducible install.

Publish the git dependency to npm or a private package repository and consume it from there.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/underscore@1.9.1
  • @SocketSecurity ignore npm/web3@0.20.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants