Holdings unset updates #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klinga
reviewed
Nov 7, 2024
klinga
reviewed
Nov 7, 2024
klinga
reviewed
Nov 7, 2024
klinga
approved these changes
Nov 7, 2024
We don't have any live tests for any of the /manage/lhrs endpoints but we could create and then delete an LHR in a live test in the same way that we have live tests that set and then unset holdings. We could also incorporate a test of cascadeDelete in those tests. Even though it isn't the package's responsibility to confirm cascadeDelete is performed correctly on the OCLC side, it would still be good to have live tests that confirm the package works with the LHR endpoints. I might add this to the PR for the monthly live tests or I might just create an issue for it so we can add it at some point in the future. |
charlottekostelic
added a commit
that referenced
this pull request
Dec 4, 2024
* Authorization server scope changes (#111) * updated dependencies and version * updated WorldcatAccessToken with scope/scopes changes * updated changelog and advanced docs added test * response type for metadata api methods is Response (#112) * Bug fixes (#113) * added ignore flake8 F401 for test_bookops_worldcat * added types-pyyaml as dev dependency * added type annotations removed unnecessary imports * deleted test.mrc as it is now redundant * fixed typo in import statement * exported updated dev-requirements.txt * added 3.13 to unit-tests.yaml * fixed live_keys fixture for GITHUB_ACTIONS * New /search/bibs/{oclcNumber} endpoint (#115) * added bib_search method to MetadataSession class * added section on /search/bibs/ endpoint to docs * fixed return type for bib_search method * Holdings unset updates (#114) * added cascadeDelete arg to holdings_unset methods * updated docs to reflect holdings unset changes * Monthly webtests (#116) * added yaml file for monthly live test gh action * added additional webtest for WorldcatAccessToken * updated contributing.md with info about live tests * added fixtures for live tests and monthly checks * separated live tests into two classes * renamed, simplified endpoint_params fixture * reviewing changes to MetadataSession webtests * moved webtests to separate files and directory * created separate conftest for webtests * fixed typos in conftest docstrings * separated webtests into different classes * updated monthly test schedule * added additional type annotations to conftest.py * updated live_keys fixture for posix and windows * updated triggers in monthly-api-tests.yaml * moved live_keys fixture to webtests/conftest.py * changed triggers for webtest workflow * fixed typo in conditionals * changed live_token fixture scope to reduce calls * added automatic retries to holdings tests * Updated changelog and dependencies for release v1.1.0 (#117) * updated version in __version__.py * updated changelog for version 1.1.0 * fixed date in changelog * updated release checklist and contribution guide * changed package version, added python 3.13 * updated all dependencies * added additional dependency updates to changelog * added link to detailed code changes in changelog * fixed failing test due to change in api response * updated mkdocstrings due to error caused by griffe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cascadeDeleteas an arg forMetadataSession.holdings_unsetandMetadataSession.holdings_unset_with_bibholdings_unsetandholdings_unset_with_bibmethods