-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorization server scope changes #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be worth reaching out to OCLC to confirm it. So, in the authorization server response, there are two fields, one with 'scope' and another with 'scopes', with the same values? It's a bit clunky, but maybe that's a common mistake they observed and tried to remediate.
Yes, there are now two fields ( It seems clunky but OCLC's documentation uses "scope" and "scopes" interchangeably so I suspect it is a common mistake. I didn't add I want to create a github actions workflow to run monthly to check the responses from the Metadata API and auth server so we know if OCLC changes anything. I'll include that in a future PR though. |
Thanks, Charlotte.
That's a good idea. Let's request a new WSKey just for that purpose. GitHub provides a means to securely store credentials within the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Authorization server scope changes (#111) * updated dependencies and version * updated WorldcatAccessToken with scope/scopes changes * updated changelog and advanced docs added test * response type for metadata api methods is Response (#112) * Bug fixes (#113) * added ignore flake8 F401 for test_bookops_worldcat * added types-pyyaml as dev dependency * added type annotations removed unnecessary imports * deleted test.mrc as it is now redundant * fixed typo in import statement * exported updated dev-requirements.txt * added 3.13 to unit-tests.yaml * fixed live_keys fixture for GITHUB_ACTIONS * New /search/bibs/{oclcNumber} endpoint (#115) * added bib_search method to MetadataSession class * added section on /search/bibs/ endpoint to docs * fixed return type for bib_search method * Holdings unset updates (#114) * added cascadeDelete arg to holdings_unset methods * updated docs to reflect holdings unset changes * Monthly webtests (#116) * added yaml file for monthly live test gh action * added additional webtest for WorldcatAccessToken * updated contributing.md with info about live tests * added fixtures for live tests and monthly checks * separated live tests into two classes * renamed, simplified endpoint_params fixture * reviewing changes to MetadataSession webtests * moved webtests to separate files and directory * created separate conftest for webtests * fixed typos in conftest docstrings * separated webtests into different classes * updated monthly test schedule * added additional type annotations to conftest.py * updated live_keys fixture for posix and windows * updated triggers in monthly-api-tests.yaml * moved live_keys fixture to webtests/conftest.py * changed triggers for webtest workflow * fixed typo in conditionals * changed live_token fixture scope to reduce calls * added automatic retries to holdings tests * Updated changelog and dependencies for release v1.1.0 (#117) * updated version in __version__.py * updated changelog for version 1.1.0 * fixed date in changelog * updated release checklist and contribution guide * changed package version, added python 3.13 * updated all dependencies * added additional dependency updates to changelog * added link to detailed code changes in changelog * fixed failing test due to change in api response * updated mkdocstrings due to error caused by griffe
OCLC Authorization server now accepts
scope
and/orscopes
as a parameter. Type and formatting ofscope
parameter is the same asscopes
.OCLC did not provide an update noting this change and their documentation on the Client Credentials Grant page uses the two parameters interchangeably.
Changed: