Automated Resyntax fixes #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
`false/c` is an alias for `#f` that exists for backwards compatibility.
The `define` form supports a shorthand for defining functions.
This expression is equivalent to calling the `positive?` predicate.
Keep imports in `require` sorted and grouped by phase, with collections before files.
This `if` expression can be refactored to an equivalent expression using `and`.
Bogdanp
reviewed
Dec 11, 2024
| racket/contract/base | ||
| (prefix-in d: data/pool) |
There was a problem hiding this comment.
Gonna skip this one as discussed on Discord and in jackfirth/resyntax#432 .
Bogdanp
reviewed
Dec 11, 2024
| @@ -126,7 +126,7 @@ | |||
|
|
|||
| (define (is-percent-encoded? s [encode uri-encode]) | |||
| (define num-%-matches (length (regexp-match* #rx"%" s))) | |||
| (or (and (> num-%-matches 0) | |||
| (or (and (positive? num-%-matches) | |||
There was a problem hiding this comment.
I'm also going to skip this one because I like the visual (conceptual?) "symmetry" of
(and (> x ...)
(= x ...))
|
(This was actually merged, I just dropped two of the commits.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 7 issues in 6 files.
false/c-migrationzero-comparison-to-positive?define-lambda-to-definetidy-requireif-else-false-to-and